search

razonyang / hugo-theme-bootstrap

A fast, responsive, multipurpose and feature-rich Hugo theme.
https://hbs.razonyang.com
MIT License
508 stars 166 forks source link

Items in social-links.html are listed as list items but not in a `<ul>` or `<ol>` #183

Closed SQLJames closed 3 years ago

SQLJames commented 3 years ago

This seems to not be needed, removing the Li tags from each item on the social-links.html layout seems to keep the same layout and functionality. This applies to all links in this page.

  <li class="nav-item">
    <a class="nav-link social-link" target="_blank" href="{{ .Permalink }}" title="RSS" rel="noopener noreferrer">
      <i class="fas fa-fw fa-2x fa-rss"></i>
    </a>
  </li>

vs 

    <a class="nav-link social-link" target="_blank" href="{{ .Permalink }}" title="RSS" rel="noopener noreferrer">
      <i class="fas fa-fw fa-2x fa-rss"></i>
    </a>
SQLJames commented 3 years ago

https://github.com/razonyang/hugo-theme-bootstrap/pull/184

razonyang commented 3 years ago

Closed by #184