razorRun / node-red-contrib-smartlifeair

Allow you to integrate any[almost] tuya, smart life supported devices to node-red. However, you will have to enrol these devices via Smart life air mobile app. https://www.smartlife.nz/smartlife-labs
https://roshan.digital/
13 stars 1 forks source link

Why to turn off the user id used warning? #10

Closed Nodi-Rubrum closed 4 years ago

Nodi-Rubrum commented 4 years ago

Why does your node report a successful use of user id?

"User Authenticated as XXXXXX@XXXXX.XXX" is reported over and over and over. The constant node.warn() calls reporting which user was authenticated is, frankly, annoying. Is there a way to turn off that notification? Or how about a feature add, to control the warning?

razorRun commented 4 years ago

Actually that was a feature, requested by one of a user with multiple config accounts. It should happen only on deploy or NR start. Do you get this warn in any other occasions?

On Tue, 22 Sep 2020 at 6:44 AM, Nodi-Rubrum notifications@github.com wrote:

Why does your node report a successful use of user id?

"User Authenticated as XXXXXX@XXXXX.XXX" is reported over and over and over. The constant node.warn() calls reporting which user was authenticated is, frankly, annoying. Is there a way to turn off that notification? Or how about a feature add, to control the warning?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/razorRun/node-red-contrib-smartlifeair/issues/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFB72EECJ6XGMEP6U2AXNFDSG6NJBANCNFSM4RU3XIDA .

Nodi-Rubrum commented 4 years ago

I am seeing it over and over. Every time I turn on a smart plug, every time I turn off a smart plug. Every time I toggle the power state of a smart plug, you name it, seems like every action taken, I get a warn notification.

What you intended makes sense, if I edit or change the configuration node, then it should confirmed credential success or failure. But not when I am just using the device already configured and authenticated. I am getting 30, 40 or more messages at times, because I am turning on and off like 10 plugs at a time, and more, testing said plugs.

I think a configurable option for this would me cool, let the operator/user turn on or off authorization notification, or drop it into the payload returned... but don't use node.warn() or even node.error() as blind notification. Moreover, it does not let me handle a bad authentication as a flow processing event, so I could take some action if authentication fails. For example the catch node can't see it as designed now.

Nodi-Rubrum commented 4 years ago

Oh, wait... it does authentication notification PER node? Right? That is why I am seeing it over and over. We have a lot of nodes in one flow. Still my suggestions still are applicable, make the event, notification. controllable or actionable, would be a great feature/enhancement.

razorRun commented 4 years ago

Yep.

Will try to add this once per account. I will have a look what we can do with NR.

Make sure to give this repo a star if you enjoy using it.

On Tue, 22 Sep 2020 at 8:21 AM, Nodi-Rubrum notifications@github.com wrote:

Oh, wait... it does authentication notification PER node? Right? That is why I am seeing it over and over. We have a lot of nodes in one flow. Still my suggestions still are applicable, make the event, notification. controllable or actionable, would be a great feature/enhancement.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/razorRun/node-red-contrib-smartlifeair/issues/10#issuecomment-696351651, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFB72EHQF26DOAQELBKNOJ3SG6YUFANCNFSM4RU3XIDA .

Nodi-Rubrum commented 4 years ago

Sure, thanks for being responsive to feedback and suggestions. Nice work, really like the solution, once I figure it out. :)

razorRun commented 3 years ago

Added this, Try and let me know

Nodi-Rubrum commented 3 years ago

Will do!

Nodi-Rubrum commented 3 years ago

Nice thanks again.