razorRun / react-native-vlc-media-player

React native media player for video streaming and playing. Supports RTSP, RTMP and other protocols supported by VLC player
https://roshan.digital/
MIT License
353 stars 183 forks source link

[Expo] Added support to expo-development-builds #168

Closed gstcarv closed 1 year ago

gstcarv commented 1 year ago

Expo development builds support

This PR introduces package support for custom Expo development builds, as outlined in the Expo documentation. This enhancement allows for a more streamlined and efficient development workflow by enabling the integration of additional packages into the Expo development environment.

Usage example

To setup with expo development client, the developer must insert library plugin to the app.json. The plugin also has support to older react-native versions, as described on readme. When running npx expo prebuild, all android / ios required native code will be generated to library work.

{
    "plugins": [
        [
            "react-native-vlc-media-player",
            {
                "ios": {
                    "includeVLCKit": false // should be true if react-native version < 0.61
                },
                "android": {
                    "legacyJetifier": false // should be true if react-native version < 0.71
                }
            }
        ]
    ]
}
razorRun commented 1 year ago

Hey mate Thank you for the contribution, will merge it now and should build in few minutes. Can you please give a quick test on expo and non expo proj when you get a minute

gstcarv commented 1 year ago

Yeah! I did. It seemed perfect to me.

gstcarv commented 1 year ago

This code doesn't affect non-expo projects