search

razorRun / react-native-vlc-media-player

React native media player for video streaming and playing. Supports RTSP, RTMP and other protocols supported by VLC player
https://roshan.digital/
MIT License
358 stars 187 forks source link

Conflict with react-native-ffmpeg #74

Open eliottguillaumin opened 3 years ago

eliottguillaumin commented 3 years ago

It seems this library overrides the FFmpeg version of the library react-native-ffmpeg.

I've tested my project back and fourth before and after installing react-native-vlc-media-player and when it's installed I encounter the following issue when running RNFFprobe on any video file on iOS:

Invalid data found when processing input

From the ressearch I've done this seems to be an FFmpeg v4.2.x issue. But the RNFFmpeg package uses the v4.4 release which apparently does not have this issue, so it's likely that react-native-vlc-media-player overrides it. Apps which need a vlc media player integration are very likely going to need React Native FFmpeg. A possible fix would be to update the FFmpeg integration to v4.4 or at least v4.3.

On the android side, the app really doesn't work much (seek nonfunctional, impossible to play cached files, etc...) but I suppose that it hasn't been completed yet, a small disclaimer in the README would be of help to many people trying out this library.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open for 60 days with no activity.