search

razorjack / quicksand

jQuery plugin. Reorder and filter items with a nice shuffling animation.
https://razorjack.net/quicksand/
GNU General Public License v2.0
1.86k stars 338 forks source link

fixes incompatibility with jQuery 1.9 #98

Closed awshout closed 10 years ago

awshout commented 11 years ago

jQuery 1.9 no longer supports .browser

Trendecide commented 11 years ago

There's more to it than this. I've tried this fix against qs1.3 & jq1.9.1 with no luck in any browser.

awshout commented 11 years ago

There definitely could be more to it, but I'm not experiencing any problems with quicksand 1.3 and jquery 1.9.1 after these changes. Can you link to a site or code for debugging? I'd be glad to take a look.

rarneson commented 11 years ago

This is probably not ideal since we should be feature detecting, not browser detecting. However, this patch works for me.

awshout commented 11 years ago

@rarneson Yeah, I agree with that.

pokono commented 11 years ago

Works for me. Thanks

sparkcom commented 11 years ago

jQuery 1.9 stops using jQuery.browser http://stackoverflow.com/questions/14366322/error-jquery-ui-draggable-cannot-read-property-msie

and quicksand definitely not working on Chrome. I got this error in console:

Error: Uncaught TypeError: Cannot read property 'msie' of undefined.

alangvara commented 11 years ago

Works well, thank you!

1updesign commented 11 years ago

thanks :D

razorjack commented 10 years ago

Merged in (and combined with other pull request that uses feature detection instead of browser detection). Thanks!