search

razorness / vue-maplibre-gl

Vue 3 plugin for maplibre-gl-js
81 stars 19 forks source link

Modernize and clean up #40

Closed rotu closed 1 year ago

rotu commented 2 years ago

Fix the build. Bump dependencies Remove babel, autoprefixer, @rollup/plugin-replace, @rollup/plugin-babel replace rollup-plugin-typescript with @rollup/plugin-typescript

razorness commented 1 year ago

Hi, I will take a look into this tomorrow.

Sieboldianus commented 1 year ago

Tried to check this out locally and got:

error css-minimizer-webpack-plugin@3.4.1: The engine "node" is incompatible with this module. Expected version ">= 12.13.0". Got "12.10.0"
error Found incompatible module.
rotu commented 1 year ago

@razorness Could you take another look? I've switched to vite, since Vue CLI is in maintenance mode.

@Sieboldianus Node 12 is unsupported and unmaintained. I'd recommend updating. https://nodejs.org/en/download/

rotu commented 1 year ago

I renamed to better reflect the nature of this PR. It's not "broken" per se, but now the dev dependencies should be easier to meet. Particularly, the demo project and the actual build both use rollup (vue-cli used to use webpack).

Before:

npx howfat --dev-dependencies
Dependencies: 2752 Size: 294.66mb Files: 36980

After:

npx howfat --dev-dependencies
Dependencies: 169 Size: 213.59mb Files: 6266

razorness commented 1 year ago

Okay. I am very busy but I have to take a look on your work. Give me few days.

rotu commented 1 year ago

@razorness, working on anything fun?

razorness commented 1 year ago

@rotu I just refactored many parts of the lib, switched to vitejs and upgraded to maplibre gl js v2. I guess, there are a lot of conflicts now with your fork.