search

razorpay / blade

Design System that powers Razorpay
https://blade.razorpay.com
MIT License
507 stars 142 forks source link

BorderStyle support in Box Component #1438

Closed Gurmanjot closed 1 year ago

Gurmanjot commented 1 year ago

borderStyle prop is not supported by the Box component. Currently the only way to get a border is to pass boxWidth- Top/down/left/right and not with boxWidth itself.

Adding either of the props borderStyle or boxWidth to hasBorder constant (here) will work.

saurabhdaware commented 1 year ago

boxWidth

You mean borderWidth?

Added it in this PR https://github.com/razorpay/blade/pull/1361#discussion_r1259182853. Will be resolved when it is merged.

Can also create a separate PR if you're blocked on this.

Gurmanjot commented 1 year ago

You mean borderWidth?

Yes, borderWidth.

chaitanyadeorukhkar commented 1 year ago

@snitin315 can you check this out?

chaitanyadeorukhkar commented 1 year ago

Raising a separate PR for this since its a P0 #1445 .