razorpay / i18nify

One stop solution for all your internationalisation needs.
https://geosmart.razorpay.com/
15 stars 3 forks source link

Feat: static configs in phone module replaced with i18nify-data #124

Closed tarun-khanna closed 5 months ago

tarun-khanna commented 5 months ago

Description

DIAL_CODE_MAPPER, PHONE_REGEX_MAPPER, PHONE_FORMAT_MAPPER replaced with i18nify-data json configs for phone number module

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link https://razorpay.atlassian.net/browse/ATLAS-169
Slack thread (if any) NA
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

Reviewer Checklist


PR Title Format

Format: <type>: <subject>

Types can be as follows:

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 06aad4bee92139b5f768fe63f2c5c9ac27b058c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @razorpay/i18nify-js | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 939dbe8d.

rzpcibot commented 5 months ago
Warnings
:warning: Your PR has over 600 lines of code additions :scream: . Try to breakup into separate PRs :+1:
:warning: **package.json**: package.json is modified, do get this reviewed by gatekeepers ! 😇

Bundle Size Report

Files

click to expand/collapse
| 🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced | | --- | --- | --- | --- | --- |
Parsed (kb)
🚦 File Name Base PR Diff %
👍 cjs/index.js 164.27 143.55 $\textcolor{green}{-20.72}$ -12.61
📈 esm/index.min.js 52.33 53.68 $\textcolor{red}{1.35}$ 2.58
👍 umd/index.js 180.84 162.97 $\textcolor{green}{-17.87}$ -9.88

Generated by :no_entry_sign: dangerJS against 06aad4bee92139b5f768fe63f2c5c9ac27b058c7

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.03%. Comparing base (1047227) to head (939dbe8). Report is 13 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #124 +/- ## ========================================== + Coverage 95.00% 95.03% +0.02% ========================================== Files 44 41 -3 Lines 501 504 +3 Branches 128 129 +1 ========================================== + Hits 476 479 +3 Misses 24 24 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 184a776d.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 9dd6768b.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 06aad4be.