Closed tarun-khanna closed 5 months ago
Latest commit: 06aad4bee92139b5f768fe63f2c5c9ac27b058c7
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 939dbe8d.
Warnings | |
---|---|
:warning: | Your PR has over 600 lines of code additions :scream: . Try to breakup into separate PRs :+1: |
:warning: | **package.json**: package.json is modified, do get this reviewed by gatekeepers ! 😇 |
Parsed (kb) | |||||
---|---|---|---|---|---|
🚦 | File Name | Base | PR | Diff | % |
👍 | cjs/index.js |
164.27 |
143.55 |
$\textcolor{green}{-20.72}$ | -12.61 |
📈 | esm/index.min.js |
52.33 |
53.68 |
$\textcolor{red}{1.35}$ | 2.58 |
👍 | umd/index.js |
180.84 |
162.97 |
$\textcolor{green}{-17.87}$ | -9.88 |
Generated by :no_entry_sign: dangerJS against 06aad4bee92139b5f768fe63f2c5c9ac27b058c7
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.03%. Comparing base (
1047227
) to head (939dbe8
). Report is 13 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 184a776d.
0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 9dd6768b.
0 files 0 suites 0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 06aad4be.
Description
DIAL_CODE_MAPPER, PHONE_REGEX_MAPPER, PHONE_FORMAT_MAPPER
replaced with i18nify-data json configs for phone number moduleChanges Made
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>
Types can be as follows:
feat
: (new feature for the user, not a new feature for build script)fix
: (bug fix for the user, not a fix to a build script)docs
: (changes to the documentation)style
: (formatting, missing semi colons, etc; no production code change)refactor
: (refactoring production code, eg. renaming a variable)test
: (adding missing tests, refactoring tests; no production code change)chore
: (updating grunt tasks etc; no production code change)