razorpay / i18nify

One stop solution for all your internationalisation needs.
https://geosmart.razorpay.com/
21 stars 10 forks source link

fix: currency symbol placement evaluation [ATLAS-199] #146

Closed RgnDunes closed 6 months ago

RgnDunes commented 6 months ago

Description

This PR changes the logic for currency symbol placement evaluation used by formatToParts utilities.

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link https://razorpay.atlassian.net/browse/ATLAS-199
Slack thread (if any) NA
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

Reviewer Checklist


PR Title Format

Format: <type>: <subject>

Types can be as follows:

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 764d9d1f331edcc3a2bad5b9ed5918c95f955a67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @razorpay/i18nify-js | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 6 months ago

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 6ec2047e.

rzpcibot commented 6 months ago

Bundle Size Report

Files

click to expand/collapse
| 🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced | | --- | --- | --- | --- | --- |
Parsed (kb)
🚦 File Name Base PR Diff %
📈 cjs/index.js 146.13 146.22 $\textcolor{red}{0.09}$ 0.06
📈 esm/index.min.js 52.74 52.79 $\textcolor{red}{0.05}$ 0.09
📈 umd/index.js 166.67 166.76 $\textcolor{red}{0.09}$ 0.05

Generated by :no_entry_sign: dangerJS against 764d9d1f331edcc3a2bad5b9ed5918c95f955a67

github-actions[bot] commented 6 months ago

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 67f2c110.

github-actions[bot] commented 6 months ago

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit c5605053.

github-actions[bot] commented 6 months ago

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 764d9d1f.