razorpay / i18nify

One stop solution for all your internationalisation needs.
https://geosmart.razorpay.com/
21 stars 10 forks source link

[fix]: fix i18nify currency inconsistency [ATLAS-204] #154

Closed RgnDunes closed 5 months ago

RgnDunes commented 5 months ago

Description

INTL returns $ for many currency codes but more localised symbol for that currency code is different from what INTL provides. This PR fixes this issue.

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link https://razorpay.atlassian.net/browse/ATLAS-204 , https://razorpay.atlassian.net/browse/ROW-173
Slack thread (if any) https://razorpay.slack.com/archives/C06C3C0SJPM/p1716446140879209
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

Reviewer Checklist


PR Title Format

Format: <type>: <subject>

Types can be as follows:

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 3cd696e0e7762823be938aafb0b1d17f4bf7ec01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @razorpay/i18nify-js | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit eb7d4d6b. ± Comparison against base commit 8e09b9de.

rzpcibot commented 5 months ago
Warnings
:warning: Your PR has over 600 lines of code additions :scream: . Try to breakup into separate PRs :+1:
:warning: this formatNumberToParts.ts has over 600 lines of code additions :scream: . Try to breakup into separate functions/components :+1:

Bundle Size Report

Files

click to expand/collapse
| 🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced | | --- | --- | --- | --- | --- |
Parsed (kb)
🚦 File Name Base PR Diff %
🟢 cjs/index.js 151.85 151.85 $\textcolor{green}{0}$ 0
🟢 esm/index.min.js 54.58 54.58 $\textcolor{green}{0}$ 0
🟢 umd/index.js 172.93 172.93 $\textcolor{green}{0}$ 0

Generated by :no_entry_sign: dangerJS against 3cd696e0e7762823be938aafb0b1d17f4bf7ec01

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 9d6e0a8c. ± Comparison against base commit 8e09b9de.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.65%. Comparing base (8e09b9d) to head (3cd696e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #154 +/- ## ========================================== + Coverage 96.53% 96.65% +0.12% ========================================== Files 48 51 +3 Lines 663 687 +24 Branches 162 168 +6 ========================================== + Hits 640 664 +24 Misses 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 5c419392. ± Comparison against base commit 8e09b9de.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit e01cc330. ± Comparison against base commit 8e09b9de.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 2be15807. ± Comparison against base commit 8e09b9de.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 60d9d3c1. ± Comparison against base commit 8e09b9de.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 2b660317. ± Comparison against base commit 8e09b9de.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 3cd696e0. ± Comparison against base commit 8e09b9de.

github-actions[bot] commented 5 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 89e7ca9d. ± Comparison against base commit 8e09b9de.