razorpay / i18nify

One stop solution for all your internationalisation needs.
https://geosmart.razorpay.com/
21 stars 10 forks source link

chore: enhance error message clarity and verbosity [ROW-252] #160

Closed RgnDunes closed 4 months ago

RgnDunes commented 4 months ago

Description

This pull request refactors the error messages throughout the codebase to be more verbose and descriptive. The changes aim to provide clearer and more detailed information about the errors, making it easier for developers to understand what went wrong and how to fix it.

Changes include:

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link https://razorpay.atlassian.net/browse/ROW-252
Slack thread (if any) https://razorpay.slack.com/archives/C072GV03Z6D/p1719845063234929?thread_ts=1719492341.561969&cid=C072GV03Z6D
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

Reviewer Checklist


PR Title Format

Format: <type>: <subject>

Types can be as follows:

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: fe66808585aed6aeda277375bbba341e3bbcf566

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ----------------------- | ----- | | @razorpay/i18nify-js | Minor | | @razorpay/i18nify-react | Major | | i18nify-playground | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 4 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 8fd537b1. ± Comparison against base commit 18cbfdf3.

github-actions[bot] commented 4 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit c4302a3a. ± Comparison against base commit 18cbfdf3.

rzpcibot commented 4 months ago

Bundle Size Report

Files

click to expand/collapse
| 🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced | | --- | --- | --- | --- | --- |
Parsed (kb)
🚦 File Name Base PR Diff %
📈 cjs/index.js 154.02 158 $\textcolor{red}{3.98}$ 2.58
📈 esm/index.min.js 56.25 60.11 $\textcolor{red}{3.86}$ 6.86
📈 umd/index.js 175.15 179.13 $\textcolor{red}{3.98}$ 2.27

Generated by :no_entry_sign: dangerJS against fe66808585aed6aeda277375bbba341e3bbcf566

github-actions[bot] commented 4 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 8dd0eae6. ± Comparison against base commit 18cbfdf3.

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (b341faa) to head (fe66808).

Files Patch % Lines
...ules/.internal/utils/getIntlInstanceWithOptions.ts 50.00% 1 Missing :warning:
...es/i18nify-js/src/modules/currency/formatNumber.ts 50.00% 1 Missing :warning:
...ify-js/src/modules/currency/formatNumberByParts.ts 50.00% 1 Missing :warning:
.../i18nify-js/src/modules/dateTime/formatDateTime.ts 50.00% 1 Missing :warning:
...i18nify-js/src/modules/dateTime/getRelativeTime.ts 50.00% 1 Missing :warning:
...ges/i18nify-js/src/modules/dateTime/getWeekdays.ts 50.00% 1 Missing :warning:
...s/i18nify-js/src/modules/dateTime/parseDateTime.ts 50.00% 1 Missing :warning:
packages/i18nify-js/src/modules/dateTime/utils.ts 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #160 +/- ## ========================================== - Coverage 96.70% 96.59% -0.12% ========================================== Files 51 51 Lines 699 704 +5 Branches 171 173 +2 ========================================== + Hits 676 680 +4 - Misses 23 24 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 2aba6321. ± Comparison against base commit 18cbfdf3.

github-actions[bot] commented 4 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit a75fe67b. ± Comparison against base commit 18cbfdf3.

github-actions[bot] commented 4 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit fe668085. ± Comparison against base commit b341faa7.

github-actions[bot] commented 4 months ago

Unit Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 228ad00d. ± Comparison against base commit b341faa7.