Open includerajat opened 1 month ago
Latest commit: 636a4a7273f8b2dcef52a2d8c68d51162ec99015
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@RgnDunes , flags are not showing because dialCodeCountryCodeMap
value is 001
and by the logic, it tries to fetch the flag with this https://unpkg.com/@razorpay/i18nify-js@1.12.2/lib/assets/flags/${value}.svg
.
Value needs to update in phoneNumber.js
↗, after that, it would automatically shows the correct flag.
It means, there is no changes need here, only needs to update the changes in that file only, because 001
wouldn't be the code of the any country.
I have fixed the missing flag issue by updating the base path for the flag source and I tested the same thing after updaing, and I made a video for the same and we can check here → https://app.screencast.com/a6nxZYx8p8qbe
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Changes Made
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>
Types can be as follows:
feat
: (new feature for the user, not a new feature for build script)fix
: (bug fix for the user, not a fix to a build script)docs
: (changes to the documentation)style
: (formatting, missing semi colons, etc; no production code change)refactor
: (refactoring production code, eg. renaming a variable)test
: (adding missing tests, refactoring tests; no production code change)chore
: (updating grunt tasks etc; no production code change)