razorpay / i18nify

One stop solution for all your internationalisation needs.
https://geosmart.razorpay.com/
21 stars 10 forks source link

Fix missing flag issue in "Phone Number" section #175

Open includerajat opened 1 month ago

includerajat commented 1 month ago

I have fixed the missing flag issue by updating the base path for the flag source and I tested the same thing after updaing, and I made a video for the same and we can check here → https://app.screencast.com/a6nxZYx8p8qbe

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link NA
Slack thread (if any) NA
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

Reviewer Checklist


PR Title Format

Format: <type>: <subject>

Types can be as follows:

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 636a4a7273f8b2dcef52a2d8c68d51162ec99015

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

includerajat commented 1 month ago

@RgnDunes , flags are not showing because dialCodeCountryCodeMap value is 001 and by the logic, it tries to fetch the flag with this https://unpkg.com/@razorpay/i18nify-js@1.12.2/lib/assets/flags/${value}.svg.

Value needs to update in phoneNumber.js , after that, it would automatically shows the correct flag.

It means, there is no changes need here, only needs to update the changes in that file only, because 001 wouldn't be the code of the any country.

image