search

razorpay / ifsc-api

:bank: Standalone API for IFSC codes
MIT License
81 stars 39 forks source link

some ifsc codes giving branch names containing special characters #16

Closed sriksm19 closed 6 years ago

sriksm19 commented 6 years ago

this one is for ICIC0006255. instead of MYSORE MAIN it has an additional á.

image

Would give you more soon if encountered.

sriksm19 commented 6 years ago

just saw your ICICI.json file. looks like its almost everywhere in it image

captn3m0 commented 6 years ago

This is an encoding issue at RBI end. You can verify this by downloading the original RBI excel sheets as well.

See https://github.com/razorpay/ifsc/issues/32 and https://github.com/razorpay/ifsc/issues/29

If you have a suggestion on how this can be handled cleanly, feedback is welcome :+1:

sriksm19 commented 6 years ago

https://stackoverflow.com/questions/10207354/how-to-remove-all-of-the-diacritics-from-a-file would this help? (probably replace the diacritic with space or empty char)

or https://stackoverflow.com/questions/3264915/remove-non-ascii-characters-in-a-file ?

PS: i havent written bash codes .. yet..

PPS: + i just mailed rbi regd this issue.. hope they check and correct it in this century

captn3m0 commented 6 years ago

These are all encoding issues. Likely newlines and other characters getting converted. However, I'd rather have RBI fix these at their end.

captn3m0 commented 3 years ago

RBI doesn't seem to be keen to fix these, so these are now cleaned up in the release. Accuracy is not guaranteed, but if you notice an issue starting from 1.5.13 release - please create a new issue.

Note that the changes aren't live at ifsc.razorpay.com yet, but should be there soon.