search

razorpay / ifsc

:bank: IFSC Codes Repository
https://ifsc.razorpay.com
MIT License
338 stars 129 forks source link

Automation Improvements #17

Closed captn3m0 closed 4 years ago

captn3m0 commented 7 years ago

A few things are missing from the setup that would make things far far better:

  1. Diff the generated IFSC.json against the one in the repo. If there are changes, throw a notification on Slack
  2. Have a tag-initiated release workflow on wercker. Only trigger on a tag push, create a new release on GitHub.
  3. Setup a release template. Use some cut/awk/sed magic on top of git diff -U0|grep IFSC | sort -u against the latest IFSC-API master to generate a diff of the list of IFSC codes.
  4. Make sure that all the usual files are uploaded on the release and that it remains in draft stage
  5. Have a check in the release pipeline to ensure package.json matches the tag
  6. Run npm publish as well?

Release Template

Should include:

  1. Diff of IFSC codes (if any). Otherwise state: "No metadata changes"
  2. A cute animal picture. Or leave it as a TODO for the person who does the final release
  3. A summary of any new banks that were added in this new release. Diff banknames.json for this.
  4. A total counter summary of additions and removals for this release
  5. The date the release was done by RBI and us (RBI comes from the website itself).
captn3m0 commented 6 years ago

Release template is now auto-generated for every release/* branch.

captn3m0 commented 4 years ago

Most of this is automated in the current release process.