Contact field is probably being stored as a float number

razorpay / ifsc

:bank: IFSC Codes Repository

https://ifsc.razorpay.com

MIT License

338 stars 131 forks source link

Contact field is probably being stored as a float number #3

Closed steelrooter closed 8 years ago

steelrooter commented 8 years ago

Response for https://ifsc.razorpay.com/HDFC0001993

{"BANK":"HDFC BANK","IFSC":"HDFC0001993","BRANCH":"HSR LAYOUT","ADDRESS":"HSR LAYOUT NO.446, 17TH CROSS 4TH SECTOR, HSR LAYOUT BANGALORE KARNATAKA", "CONTACT":9945863333.0 ,"CITY":"BANGALORE","DISTRICT":"BANGALORE URBAN","STATE":"KARNATAKA"}

captn3m0 commented 8 years ago

I always assumed that was because of the RBI excel sheets itself (it's not). Maybe we should force it to a string.

steelrooter commented 8 years ago

Do we clean this field while importing?

captn3m0 commented 8 years ago

Currently, no: https://github.com/razorpay/ifsc/blob/34448ac10832a596cbc6e4758a81deceaa3b3c91/scripts/methods.rb

Should be easy enough

captn3m0 commented 8 years ago

working on this