Get NPM package to parity with PHP

captn3m0 commented 6 years ago

NPM package does not support:

nihalgonsalves commented 6 years ago

Happy to help on this one

Parikshit-Hooda commented 6 years ago

hey ! can you explain the objective a little more clearly? i dont understand it. As far as i can understand, you want me to port code from php to nodejs.. but the point is ;i dont know php. How do you propose we proceed from here?

captn3m0 commented 6 years ago

Hi @nihalgonsalves, thanks for the offer 👍. We're doing this as part of CMoC and @Parikshit-Hooda will be taking this up.

More details on the task:

Right now there is a feature parity mismatch between the PHP package (which we use internally) and the NPM package. Mostly because we (@Razorpay) use the PHP package in our codebase, and the NPM one is not.

The idea is to have the same features (don't think in terms of porting of code) in the NPM side. The NPM package already supports client-side validations (source), and needs more things.

I'd suggest going in the following order:

Adding support for fetching details from the API. This would involve depending on another package like request and returning the correct response (or an error). Input = IFSC code, response = object containing details from the IFSC API. This method is already stubbed out in the codebase as "not implemented"
Adding a getBankCode method. The initial functionality is basic (return first four characters), and then you need to read the PHP code to understand the rest (reading sublet.json, and using it correctly)

I'd ideally want the first to be done using promises (since it is a network request), and tests as well.

Parikshit-Hooda commented 6 years ago

i am on it. Can I communicate with you on whatsapp too?

captn3m0 commented 4 years ago

Other than sublet support, the rest are done.

https://github.com/razorpay/ifsc#support-matrix

Closing this, and creating a new ticket just for that.

razorpay / ifsc

Get NPM package to parity with PHP #59