search

razorpay / razorpay-flutter

Razorpay Flutter Plugin
MIT License
106 stars 144 forks source link

Why these dependencies in your package #363

Open junaid1460 opened 6 months ago

junaid1460 commented 6 months ago

I see that you have flutter toast and package info plus in as deps in your package, it just adds useless transitive deps for us, which complicates distribution further. Could you just require whatever the information you need from the integrators?

Screenshot 2024-01-03 at 12 33 26 PM

Kinda have to maintain a separate version of this package now, if it takes time

vivekshindhe commented 6 months ago

We will look into removing the flutter_toast package. But the package_info_plus is required for passing the Vulnerability check on Google Play Store. Will look into this further but there will be a delay by the time we get to this. Does adding these increase the size of your app by a lot? If possible could you please give a number for the same? Thanks for bringing this to our attention @junaid1460

junaid1460 commented 6 months ago

The requirement comes out where I have to ship a flutter module for a third party, where only required modules should be present. While I have made the whole product injected, some transitive dependencies like this will add more complexity to the process

junaid1460 commented 6 months ago
Screenshot 2024-01-03 at 1 12 40 PM

This is where you need package name, am I right? Why not require it in initialisation? As an integrator I will provide you with that ? Kind of thinking packages like this should be abstract enough

junaid1460 commented 6 months ago

Gon fork and override for now

vivekshindhe commented 6 months ago

It would be great if you can wait a couple of days for this. If you are going to fork it, please fork from this commit (a958e4eb8a5d8c2f01ab024c7dab1875e3129d49) to avoid issues.

junaid1460 commented 6 months ago

yeah sure. when you do, bump major version, I'll get to know.

utrayn commented 5 months ago

Hello, Please update the package_info_plus dependency to the latest version in your package. As of writing this comment, latest version is package_info_plus: ^5.0.1 and you are using package_info_plus: ^4.0.1 Thanks.

utrayn commented 3 months ago

Hello,

I had marked a comment on February 2, 2024, regarding this. Reminding once again.

Please update the package_info_plus dependency to the latest version in your package. As of writing this comment, latest version is package_info_plus: ^6.0.0 and you are using package_info_plus: ^4.0.1. This is causing a major problem in our apps and is a blocker issue.

Thanks.

sohelyadav commented 2 months ago

kindly update package_info_plus dependency. Thanks