search

razorpay / razorpay-node

Razorpay node.js bindings
MIT License
182 stars 111 forks source link

Replace the request package by something else (DEPRECATED) #343

Open mahmoud-triki opened 1 year ago

mahmoud-triki commented 1 year ago

Steps to reproduce the behavior

Here you find the deprecation warning, it has been deprecated for more than 3 years.

you can do npm install and you can see the deprecation warning.

Expected behavior

Not using a deprecated package

Actual behavior

The razorpay is depending on the request package which deprecated.

Code snippets

No response

Node version

All

Library version

2.8.6

Additional Information

This can be replaced by axios for example

mahmoud-triki commented 1 year ago

By the way the sam thing applies to the request-promise package as well

sreenidhithallam commented 1 year ago

@mahmoud-triki even the request-promise package is also deprecated. can I pick this up and replace it with axios.

ShivamJoker commented 1 year ago

@ankitdas13 mind simply using node-fetch based on the Node runtime? It's already there since node18, so you can load this lazily when someone is on below version.

AnuragBalhra commented 1 year ago

@mahmoud-triki even the request-promise package is also deprecated. can I pick this up and replace it with axios.

I think it's good idea to use axios. Is someone already working on this change? If not, maybe I could try implementing it?