search

razorpay / razorpay-python

Razorpay Python SDK
https://pypi.python.org/pypi/razorpay
MIT License
153 stars 81 forks source link

BugFix:Edit Subscription function name change #225

Open sid10on10 opened 2 years ago

sid10on10 commented 2 years ago

Razorpay documentation states that the subscription should be updated - client.subscription.update(subscriptionId, options)

Reference - https://razorpay.com/docs/api/payments/subscriptions/#update-a-subscription

So Edit subscription Function should be named to update

Related Issue - https://github.com/razorpay/razorpay-python/issues/224

kkyusufk commented 2 years ago

You will need to update the unit tests for the checks to pass.

sid10on10 commented 2 years ago

@kkyusufk I have updated the test cases. You can review and merge.

kkyusufk commented 2 years ago

@sid10on10 Looks good! Will review this with other folks and hopefully this should be merged by tomorrow. Thanks for the contribution! 😄

sid10on10 commented 2 years ago

@kkyusufk I want to contribute more to Razorpay Python.Let me know the best things to get started.

kkyusufk commented 2 years ago

started

Hi @sid10on10, Thanks for your interest in contributing. During the course of the next couple of weeks, we will be adding some agenda items and a roadmap for features we would want to add to this sdk. We will open some issues which can be picked by anyone either from razorpay or outside razorpay. So keep an eye on that issues filter 😄

sid10on10 commented 2 years ago

@ankitdas13 @kkyusufk Thanks for the feedback. I look forward to contributing.