search

razorpay / razorpay-python

Razorpay Python SDK
https://pypi.python.org/pypi/razorpay
MIT License
153 stars 81 forks source link

Fix python matrix on GitHub Actions #265

Open SubhrajyotiSen opened 10 months ago

SubhrajyotiSen commented 10 months ago

  1. Currently, the Action doesn't use the matrix correctly. This leads to the default python version of 3.11.5 being installed every time. You can see that at https://github.com/SubhrajyotiSen/razorpay-python/actions/runs/6550129767/job/17788570158 Use the python-version variable during the installation step to pick up the correct value from the matrix. Making this change also reveals specifying "3.10" as Integer tries to install Python 3.1, which doesn't exist. Hence specify the versions as String.

  2. As per https://github.com/actions/setup-python/issues/544, ubuntu-latest doesn't have all the needed Python version. Hence we need to specify Ubuntu 20.04

  3. https://github.com/actions/python-versions/blob/main/versions-manifest.json specifies the Python versions available. According to it, Python 3.0.x is not available on Ubuntu. Hence remove it. I can add support for it by introducing a windows runner

SubhrajyotiSen commented 6 months ago

Rebased the PR over master

SubhrajyotiSen commented 6 months ago

@hariprasadpo28 Can you please review this?