search

razorpay / razorpay-woocommerce

Razorpay Payment Extension for Woocommerce
https://wordpress.org/plugins/woo-razorpay/
GNU General Public License v2.0
40 stars 30 forks source link

Cart is reset if payment fails or is cancelled #131

Closed thesfboy closed 5 years ago

thesfboy commented 5 years ago

The cart gets reset if payment fails or if customer cancels the transaction. This means, the customer has to look for the products again and then add to the cart. This could lead to the customer just walking off from the site and not returning. When will this be corrected? Doesn't happen with PayPal or PayTM.

harman28 commented 5 years ago

Which version of razorpay-woocommerce are you using?

thesfboy commented 5 years ago

2.3.0

On Tue, Nov 5, 2019 at 12:33 PM Harman Singh notifications@github.com wrote:

Which version of razorpay-woocommerce are you using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/razorpay/razorpay-woocommerce/issues/131?email_source=notifications&email_token=AK7QV2YSD77SMSZIC4JTYEDQSELC7A5CNFSM4JIYYI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDBZ3NI#issuecomment-549690805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7QV24FL7LNCJ6RE6256TTQSELC7ANCNFSM4JIYYI6A .

harman28 commented 5 years ago

Thank you for reporting this. We think this might be an issue in our latest release, 2.3.0. We're working on a fix now, and will release it soon.

If you'd rather not wait, you also can consider using an older release.

thesfboy commented 5 years ago

Thanks. The older release is really crap. I kept getting literally hundreds of mails saying Webhook failed.

On Tue, Nov 5, 2019 at 12:54 PM Harman Singh notifications@github.com wrote:

Thank you for reporting this. We think this might be an issue in our latest release, 2.3.0. We're working on a fix now, and will release it soon.

If you'd rather not wait, you also can consider using an older release https://github.com/razorpay/razorpay-woocommerce/releases/tag/v2.1.0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/razorpay/razorpay-woocommerce/issues/131?email_source=notifications&email_token=AK7QV26Y66KXNK7ZJBOUEJTQSENTHA5CNFSM4JIYYI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDB3ISQ#issuecomment-549696586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7QV23QT25AHKE4WITHORTQSENTHANCNFSM4JIYYI6A .

harman28 commented 5 years ago

Can you share the content of one of the webhook failure mails here? The mail should ideally contain the error message that Razorpay received when trying to send a webhook to your server.

harman28 commented 5 years ago

Alternately, if you're willing to share your merchant ID here, I can take a look at the webhook failures myself.

thesfboy commented 5 years ago

Thanks for helping out. Let me know once you've copied the id so that I can delete it from here.

On Tue, Nov 5, 2019 at 1:04 PM Jigar Budhdev jbudhdev@gmail.com wrote:

B1cucsWbusBG1y

On Tue, Nov 5, 2019 at 1:00 PM Harman Singh notifications@github.com wrote:

Alternately, if you're willing to share your merchant ID here, I can take a look at the webhook failures myself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/razorpay/razorpay-woocommerce/issues/131?email_source=notifications&email_token=AK7QV24VL3JUG75QCVY7C4LQSEOITA5CNFSM4JIYYI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDB3UWA#issuecomment-549698136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7QV257QJJ6SPCMYPAI4PTQSEOITANCNFSM4JIYYI6A .

harman28 commented 5 years ago

I have copied it. However, merchant IDs can be shared publicly, they do not grant access to any private resources or APIs.

thesfboy commented 5 years ago

Thanks. Good to know.

On Tue, Nov 5, 2019, 1:06 PM Harman Singh notifications@github.com wrote:

I have copied it. However, merchant IDs can be shared publicly, they do not grant access to any private resources or APIs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/razorpay/razorpay-woocommerce/issues/131?email_source=notifications&email_token=AK7QV2ZFITXLGFJ3MJVSB5TQSEPAPA5CNFSM4JIYYI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDB4CNI#issuecomment-549699893, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7QV23WPMXTN5TNIZTRRFLQSEPAPANCNFSM4JIYYI6A .

harman28 commented 5 years ago

Checked the failures that happened on 7th September as reported here. The most frequent failure reason was an operation timeout message that we received mostly between 4.30am and 9am:

No response received due to network issues: cURL error 28: Operation timed out after 10001 milliseconds with 0 bytes received (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)
Screenshot 2019-11-05 at 1 25 00 PM

It'll be hard to debug what exactly went wrong during this time without access to your server logs, but from the looks of things your server was simply acting up and showing high latency for this 5 hour period, causing webhooks requests to fail and subsequently be retried.

There's also a spike in successful webhook deliveries starting at 9am, which I take to mean that the failing webhooks did eventually get delivered, just after a lot of attempts:

Screenshot 2019-11-05 at 1 20 25 PM

Our webhooks are configured to keep retrying until there's a 24-hour period of no successes, following which the webhook is disabled. I understand that the avalanche of failure notification emails can be quite annoying for a site admin, especially one who's already facing server issues in other parts of their app, which caused the failures in the first place. There should probably be more effective throttling on emails in general.

If you have any other suggestions about how this could've been better handled, i.e. how a failing webhook should be effectively notified to the site admin without flooding one's inbox, please let me know. I'll try and get it added to our roadmap for the next quarter.

thesfboy commented 5 years ago

Well. My site was definitely up and running and we logged quite a few transactions through other gateways. Not the first time this happened with Razorpay. None of my other webhooks had this issue.

On Tue, Nov 5, 2019, 1:32 PM Harman Singh notifications@github.com wrote:

Checked the failures that happened on 7th September as reported here https://github.com/razorpay/razorpay-woocommerce/issues/126. The most frequent failure reason was an operation timeout message that we received mostly between 4.30am and 9am:

No response received due to network issues: cURL error 28: Operation timed out after 10001 milliseconds with 0 bytes received (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)

[image: Screenshot 2019-11-05 at 1 25 00 PM] https://user-images.githubusercontent.com/4201494/68188985-71db7900-ffd0-11e9-96ae-db3b509874fc.png

It'll be hard to debug what exactly went wrong during this time without access to your server logs, but from the looks of things your server was simply acting up and showing high latency for this 5 hour period, causing webhooks requests to fail and subsequently be retried.

There's also a spike in successful webhook deliveries starting at 9am, which I take to mean that the failing webhooks did eventually get delivered, just after a lot of attempts: [image: Screenshot 2019-11-05 at 1 20 25 PM] https://user-images.githubusercontent.com/4201494/68189007-7f90fe80-ffd0-11e9-8dba-0adcecdba9ee.png

Our webhooks are configured to keep retrying until there's a 24-hour period of no successes, following which the webhook is disabled. I understand that the avalanche of failure notification emails can be quite annoying for a site admin, especially one who's already facing server issues in other parts of their app, which caused the failures in the first place. There should probably be more effective throttling on emails in general.

If you have any other suggestions about how this could've been better handled, i.e. how a failing webhook should be effectively notified to the site admin without flooding one's inbox, please let me know. I'll try and get it added to our roadmap for the next quarter.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/razorpay/razorpay-woocommerce/issues/131?email_source=notifications&email_token=AK7QV27VSGRTC5XIOYV3RWTQSESAXA5CNFSM4JIYYI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDB55HY#issuecomment-549707423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7QV2Z5IKRSD2IRDI5S5CDQSESAXANCNFSM4JIYYI6A .

harman28 commented 5 years ago

In that case, would you be able to check your logs and tell us why webhook requests sent to your server were regularly showing a response time of over 10 seconds? Might have been a temporary thing, since it hasn't recurred.

thesfboy commented 5 years ago

Sorry, can't do that. Don't have the time or resources. I have stopped using Razorpay because of these issues. Have not faced a single issue using PayPal or PayTM. Had escalated this issue several times over the past several months. Do check my tickets. Would get the standard response that our team is checking the issue and will get back to me. You are the first person who's actively looking into this. Thanks for that. Other users would benefit.

On Tue, Nov 5, 2019 at 2:11 PM Harman Singh notifications@github.com wrote:

In that case, would you be able to check your logs and tell us why webhook requests sent to your server were regularly showing a response time of over 10 seconds? Might have been a temporary thing, since it hasn't recurred.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/razorpay/razorpay-woocommerce/issues/131?email_source=notifications&email_token=AK7QV2Z3CXZML4FIVFDVVMDQSEWVNA5CNFSM4JIYYI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDCBDRI#issuecomment-549720517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7QV23LV36JS6ZFRM3TPGTQSEWVNANCNFSM4JIYYI6A .

harman28 commented 5 years ago

I understand, the issue is probably a little too old for you to easily fetch logs for the same.

Leaving this issue open since it has created for a different bug, i.e. cart reset. Will close when the fix is released.

ChetanGN commented 5 years ago

The cart gets reset if payment fails or if customer cancels the transaction. This means, the customer has to look for the products again and then add to the cart. This could lead to the customer just walking off from the site and not returning. When will this be corrected? Doesn't happen with PayPal or PayTM.

This issue got fixed in version 2.3.1 release.

harman28 commented 5 years ago

Thanks @ChetanGN , closing this issue.

thesfboy commented 5 years ago

Thanks. Will check it out.

On Tue, Nov 12, 2019 at 11:34 AM Harman Singh notifications@github.com wrote:

Closed #131 https://github.com/razorpay/razorpay-woocommerce/issues/131.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/razorpay/razorpay-woocommerce/issues/131?email_source=notifications&email_token=AK7QV22AGV5OOAYYJ6URQ5TQTJBOPA5CNFSM4JIYYI6KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUZH3E3Y#event-2790240879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7QV27SQCQUGFI4SFRHAZ3QTJBOPANCNFSM4JIYYI6A .

thesfboy commented 5 years ago

It still hasn't been resolved.

On Tue, Nov 12, 2019 at 11:35 AM Jigar Budhdev jbudhdev@gmail.com wrote:

Thanks. Will check it out.

On Tue, Nov 12, 2019 at 11:34 AM Harman Singh notifications@github.com wrote:

Closed #131 https://github.com/razorpay/razorpay-woocommerce/issues/131 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/razorpay/razorpay-woocommerce/issues/131?email_source=notifications&email_token=AK7QV22AGV5OOAYYJ6URQ5TQTJBOPA5CNFSM4JIYYI6KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUZH3E3Y#event-2790240879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK7QV27SQCQUGFI4SFRHAZ3QTJBOPANCNFSM4JIYYI6A .

thesfboy commented 5 years ago

Still happening. Take a look.. If the customer cancels the payment, the cart is getting reset. Screenshot 2019-11-13 at 6 55 01 PM

anatoliy-t7 commented 4 years ago

The cart gets reset if payment fails or if customer cancels the transaction. This means, the customer has to look for the products again and then add to the cart. This could lead to the customer just walking off from the site and not returning. When will this be corrected? Doesn't happen with PayPal or PayTM.

This issue got fixed in version 2.3.1 release.

The problem is still there.

ramth05 commented 4 years ago

The cart gets reset if payment fails or if customer cancels the transaction. This means, the customer has to look for the products again and then add to the cart. This could lead to the customer just walking off from the site and not returning. When will this be corrected? Doesn't happen with PayPal or PayTM.

This issue got fixed in version 2.3.1 release.

The problem is still there.

@T7team, Yes we are working on it and must be fixed in next release.