Not supporting React 18.0

razorpay / react-native-razorpay

React Native wrapper for Razorpay's mobile SDKs

https://www.npmjs.com/package/react-native-razorpay

MIT License

124 stars 107 forks source link

Not supporting React 18.0 #424

Open iamromec opened 1 year ago

iamromec commented 1 year ago

Hello Team,

The npm package https://www.npmjs.com/package/react-native-razorpay was updated 7 months ago and currently does not support React 18.0. Please find the attached screenshot for your reference. Can you please update it so we can integrate it with the gateway account?

vivekshindhe commented 1 year ago

@iamromec Fix for this and future versions, is currently in progress. It will be released tomorrow at the latest. I will update here once again when released. Just a heads up. thank you for your patience

vivekshindhe commented 1 year ago

v2.3.0 is live with support for the latest versions. Thank you for your patience. Closing the ticket now

iamromec commented 1 year ago

It seems because of the unstable plugin there are still issues with it.

As I installed the plugin, I started getting this error (FYI: I'm running it on Simulator not metro builder --- ideally it should work):

Simulator Screen Shot - iPhone 14 - 2022-11-09 at 23 43 09

There are one more error:

Test Key does not work at all; it throws this error

Hope you guys resolve these too.

vivekshindhe commented 1 year ago

Hey @iamromec

The screenshot of the YGAlign error. I don't see how the razorpay package is doing that as we don't use any dependencies whatsoever. Can you try changing it to one of the values given there?

For the second, have you tested with live keys? And/or with an actual device? I tested the builds on an iOS device. Did not face any such issues but will try to reproduce them on our end.

iamromec commented 1 year ago

The live key works fine.

Also, I'm using expo so how do we handle it during development because the app is not running after this integration? We need some way around Expo so development goes smooth.

iamromec commented 1 year ago

This is the error with the Expo client.

Simulator Screen Shot - iPhone 14 - 2022-11-10 at 00 37 31

vivekshindhe commented 1 year ago

@iamromec it's not able to access the native modules. Did you prebuild the application?

vivekshindhe commented 1 year ago

For expo, i have tested this and it works completely fine for me for some reason. Can you follow the readme doc in this for expo and see if that resolves your issues?

iamromec commented 1 year ago

@vivekshindhe could you please also answer how we handle it during development mode on Expo?

iamromec commented 1 year ago

Hi @vivekshindhe, while running the app with expo run:ios, it's throwing the following errors:

It seems there are multiple dependency issues with the plug in as you guys have may have tested with simple or vanilla app with just react-native-razorpay plugin. But in the real world app, it has many plugins and libraries installed. Please check again and reopen the case if possible.

vivekshindhe commented 1 year ago

@iamromec Reopened this. Can you share the package.json file to vivek.shindhe@razorpay.com so that I can try to reproduce this with those packages installed?

iamromec commented 1 year ago

It's throwing this error sometimes:

sandeshnaroju commented 1 year ago

Also, is react native customui support for react 18 available? custom UI is not installable with 18 currently, kindly update that too.