razorsedge / puppet-openlldp

Puppet module to install Open-LLDP.
http://forge.puppetlabs.com/razorsedge/openlldp
Other
6 stars 11 forks source link

Module doesn't work with puppet 6? #14

Open hawson opened 5 years ago

hawson commented 5 years ago

Version 1.0.0 of the module doesn't seem to work with puppet 6, and throws a large number of errors.

Simply including the module in the repository causes a ton of errors like these:

Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/facter-2.5.1/lib/facter/kernelrelease.rb: uninitialized constant Facter::Util::Config
Did you mean?  RbConfig
Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/facter-2.5.1/lib/facter/uptime_seconds.rb: wrong number of arguments (given 0, expected 2)
Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/facter-2.5.1/lib/facter/hardwareisa.rb: wrong number of arguments (given 0, expected 2)
Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/facter-2.5.1/lib/facter/zonename.rb: wrong number of arguments (given 0, expected 2)
[..snip 52 additional errors...]

All of the errors are of the same form and path. None of them appear directly related to openlldp.

The errors started when I included the the openlldp module in the "top-level" modules directory (outside of environments), and happen regardless of whether I actually have any active openlldp classes in the manifests or not (makes sense, since this appears to be fact-related). The errors go away again when I remove them.