search

razrotenberg / Midier

Arduino library for playing, recording, looping and programming MIDI notes, arpeggios and sequences
MIT License
60 stars 7 forks source link

Does it support MIDI channels? #11

Open damirka opened 3 years ago

damirka commented 3 years ago

Hello there. Maybe I'm too new in C++ world, but by looking at source code I haven't found MIDI channelling anywhere. Can you help me do this?

razrotenberg commented 3 years ago

Hi @damirka and thanks for reaching out! So I personally didn't need to control the MIDI channel and just used channel 0 hard coded. This could be easily changed though. All there needs to be done is propagate a variable all the way to send() method in midi.cpp instead of the hard coded value (https://github.com/levosos/Midier/blob/master/src/midi/midi.cpp#L17).

Let me know if you want to open a pull request with these changes or if I can help you doing that!

damirka commented 3 years ago

Okay @levosos, let's do it this way: I'll make my first PR on C++, and if there's something wrong you'll help me fix this. 😆

razrotenberg commented 3 years ago

No problem :-)