razshare / sveltekit-sse

Server Sent Events with SvelteKit
https://www.npmjs.com/package/sveltekit-sse
MIT License
301 stars 9 forks source link

Support SvelteKit v2 #18

Closed BearToCode closed 10 months ago

BearToCode commented 10 months ago

Hello, I've just updated to SvelteKit v2 and the library works fine. It would be nice to specify "@sveltejs/kit": "^1.25. 2 || ^2.0.0" in package.json to prevent a peer dependencies warning. There is also this new warning when starting the dev server:

[vite-plugin-svelte] WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte.

sveltekit-sse@0.5.0

Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition for details.
razshare commented 10 months ago

Hi @BearToCode , I agree, it shouldn't be an issue to add the peer dependency.

As for the other warning it should've been fixed a few hours ago in https://github.com/tncrazvan/sveltekit-sse/pull/17

razshare commented 10 months ago

v0.5.2 is out and the peer dependency warning is now gone.

Thank you for the issue!