razvanmarinescu / brain-coloring

BrainPainter - Brain Visualisation Software
57 stars 17 forks source link

Top and bottom view of inflated brain type is wrong #31

Closed BailiangJ closed 8 months ago

BailiangJ commented 8 months ago

Hi @razvanmarinescu ,

Thanks a lot for the great software.

The top/bottom view of brain_type='inflated' I am getting looks wrong.

figure

razvanmarinescu commented 8 months ago

Glad it's useful! Have you tried running brainpainter from source? Attach here a minimal working example as a zip, with brainpainter and the CSV biomarker table? We can't debug it otherwise.

BailiangJ commented 8 months ago

Hi @razvanmarinescu ,

Thanks for the reply.

I am using the docker with the latest repo to generate the figures.

I set BRAIN_TYPE = 'inflated', IMG_TYPE='top', use the DK_template as input, and run with the default Makefile .

And I get

top_Image_0 top_Image_1

jvengosh commented 8 months ago

Hi there!

After some digging, here's what I've found. It seems that the inflated brain type's process does not correctly preserve the shape of the brain in these views. Interestingly, what it's doing is squishing the brain (take a look at a cortical-inner-left or right view to see what I mean) and the issue is because of the polygon files used in the inflated brain type.

I'll attach an example using the same data with multiple views. I would suggest using a different brain type because the perspectives are the same for each and the information is a bit more viewable in the others. The only unintended thing seems to be the "unsquished" bits on the bottom that affect the top and bottom views.

Let me know if you need anything else!

image

razvanmarinescu commented 8 months ago

ah yes, so if you change from inflated to the standard option (I think "pial"), that should work. We didn't test extensively with the inflated or white-matter formats

BailiangJ commented 8 months ago

Hi @jvengosh @razvanmarinescu ,

Thanks a lot!

Yes, it's just only the top/bottom views of inflated having a problem. The rest are still informative and good to use.:)