razzius / weave

Source code for a platform to connect mentors with students
MIT License
7 stars 2 forks source link

Make search bar show only tags that have search results #105

Closed jjchen20 closed 4 years ago

jjchen20 commented 5 years ago

Additional ask: Change search bar text from "Search" to "Click or type something and press enter." I think people don't know that free text searching is an option.

razzius commented 5 years ago

Moved search bar text to new issue

razzius commented 4 years ago

image

I've made some progress on this, and a question has come up. Should we require hospital affiliations to be made "public" or should they always be public?

razzius commented 4 years ago

On staging, now, the /browse page will only show tags that are public. So we'll have to do some administration but the code should work.

jjchen20 commented 4 years ago

Hospital affiliations should always be "public"

jjchen20 commented 4 years ago

Showing the available public tags requires first clicking away then clicking back to the search box. Would be great if the drop down list of available tags comes up by clicking in the box, without needing to click away and then back.

jjchen20 commented 4 years ago

The fluidity of the searching with tags that have search results is dependent on #77

razzius commented 4 years ago

This feature is pretty much done and deployed to staging. Degrees are not loading dynamically yet since we have special cases of DMD / DDS and MD / DO which need additional information to specify the tags are "alias" tags or something.

jjchen20 commented 4 years ago

For the hospitals, right now the only way to remove a selected hospital filter is to clear the entire search. There should be a way to remove the hospital filter option (i.e. with a small x next to the hospital name) without clearing the entire search, in case several tags and/or degree filtering options are selected.

razzius commented 4 years ago

Good point @jjchen20. I'm adding that to a new issue: https://github.com/razzius/hms-weave/issues/176