Tag generation Issues - Githubissues

razzius / weave

Source code for a platform to connect mentors with students

MIT License

7 stars 2 forks source link

Tag generation Issues #120

Closed jjchen20 closed 5 years ago

jjchen20 commented 5 years ago

In the faculty profile generation section

jjchen20 commented 5 years ago

What should create a new tag:

Clicking away from what's been typed so far (should create the tag instead of deleting it)
Comma, semi-colon, and periods should create separate tags

razzius commented 5 years ago

2 hours dev work

razzius commented 5 years ago

Applies to all creatable tag inputs

razzius commented 5 years ago

Took about 4 hours, though I got distracted in the process. Testable on staging

razzius commented 5 years ago

I think making periods create separate tags could lead to issues, if for example if somebody wanted to put ".hack fan" or any other tag that has a period in it, this would prevent the tag from being created.

For what it's worth, currently no tags exist in the database with periods, so it's a somewhat rare case.

jjchen20 commented 5 years ago

This looks good on staging and ready to deploy. Outlining here what creates the tag:

Clicking on the pre-made tag highlighted
Clicking anywhere on the page or in another text box
Pressing the tab key
Pressing the enter key
Typing a comma
Typing a semi-colon

The search feature (#124) should also allow typing/ searching for tags using all of the options above.

jjchen20 commented 5 years ago

Can we apply the tag generation capabilities universally across all the tags (not just the open-ended ones)?

Typing in comma or semi-colon did not create/select the tag automatically for the academic degrees:

jjchen20 commented 5 years ago

Comma and semi-colon tag generation currently works for "Parts of Me" and "Activities I enjoy" but not "Academic Degrees," "Institutional Affiliations," "Clinical Interests," and "Professional Interests." Same rules across all tag generation will be more intuitive for users.

razzius commented 5 years ago

I added comma / semicolon / click elsewhere = complete for all creatable tags, which is everything but institutional affiliations. Since users cannot create institutional affiliations, I think it makes sense to have them select the affiliation via click, tab, or enter, and to discard something typed without a matching affiliation and they click elsewhere. Open to feedback on this.

jjchen20 commented 5 years ago

That makes sense to me too. See #135 for similar conversation, with bug of menus staying open only after comma/semicolon tag creation.

razzius commented 5 years ago

Also see #136