Completing tags by clicking on them, tab, or enter should make tag uppercase

razzius / weave

Source code for a platform to connect mentors with students

MIT License

7 stars 2 forks source link

Completing tags by clicking on them, tab, or enter should make tag uppercase #136

Closed razzius closed 5 years ago

razzius commented 5 years ago

In parts of me, type "asdf", click on it.

Observe "asdf" is created, when "Asdf" would be expected.

JonKusner commented 5 years ago

This looks really good, some minority hilarious behavior: 1. if you type "sdf" it does not offer to creat the tag. 2. When there is a list of options, I was not able to arrow key through the options

JonKusner commented 5 years ago

Oh no never mind on the 'sdf' stuff, I had that tag twice.

jjchen20 commented 5 years ago

The autocapitalization is working for me. Looks good!

jjchen20 commented 5 years ago

Hey Razzi - Can we make the autocapitalization present for the search feature too?

razzius commented 5 years ago

Not going to implement autocapitalization for search - it's case-insensitive search and I think the behavior would be unintuitive for users.