search

razzmatazz / csharp-language-server

Roslyn-based LSP language server for C#
MIT License
584 stars 38 forks source link

Rename action modifies comment and string words equal to Symbol text #157

Closed Myrslaver closed 3 months ago

Myrslaver commented 4 months ago

Hello, The commit 65cd66f changed the SymbolRenameOptions passed to the RenameSymbolAsync function from this

SymbolRenameOptions(RenameOverloads=true, RenameFile=true)

to this

SymbolRenameOptions(RenameOverloads = true, RenameInStrings = true, RenameInComments = true)

Which it means that every string and comment inside the solution/projects, that contains a word equal to the Symbol text, is renamed to the text of the action input. The file which contains this modification is this one: Rename.fs, line 170. I think this is a bug, and it should be reverted to the original. This project is so cool btw, thank you for your work!

razzmatazz commented 4 months ago

Hey @Myrslaver! Thank you, I concur,–old behaviour has been restored in https://github.com/razzmatazz/csharp-language-server/commit/ccee0efa44c5166e644265653b543a5a2e0fcbf0

razzmatazz commented 3 months ago

I believe this has been fixed in 0.14.0, please reopen if not so.