Fixed generators to work from a mountable Rails engine

rbCAS / CASino

CASino is a Ruby-based Single Sign-On solution supporting the CAS standard

MIT License

329 stars 189 forks source link

Fixed generators to work from a mountable Rails engine #130

Closed joelvh closed 7 years ago

joelvh commented 8 years ago

Added Rails engine "namespace" to asset paths when installing CASino. Added migrations generator to copy migrations because the built-in rake railties:install:migrations does not work when running the command on a Rails engine. It's a simple fix to copy the files.

Given, we may have a special case where we're mounting CASino in another mountable Rails engine.

pencil commented 8 years ago

Thanks for your PR. How can I reproduce the problem you are facing with the current implementation? Does this change the behavior of the most comment use case? Do we have to migrate existing installations?

joelvh commented 8 years ago

@pencil you can test this by creating a mountable Rails engine, and mounting CASino. Then (from the rails engine root) try running the generator rails g casino:install or the Rake command rake casino:install:migrations. It doesn't seem to work (with the old code), but works now with this new generator.

pencil commented 8 years ago

Does this change anything for existing installations? Are the commands still the same?

coveralls commented 7 years ago

Coverage remained the same at 97.201% when pulling fed06268949fbc50d695d0b27060599cdd32073f on identification-io:master into fed06268949fbc50d695d0b27060599cdd32073f on rbCAS:master.