Closed philippks closed 8 years ago
Thanks, this looks awesome!
There is one minor problem: Usernames in CASino are not unique. Technically the same username can be used by different authentication backends. I see two possible solutions for this:
a) No longer allow duplicated usernames and make them unique. This would require a new major release since it's not backward compatible. b) Log failed login attempts to all existing user account. Log successful attempts to the actual account that logged in.
Hey @pencil, thank you for your feedback!
After discussing with @calmyournerves, we think it is not in scope of CASino to care about the uniqueness of the usernames over multiple authenticators. So your secondly proposed solution is more pragmatically. I will make the corresponding changes.
@pencil did you already have a chance to look at this again? Thanks!
Awesome, thanks.
Logs attempts to login and displays them on the main view:![image](https://cloud.githubusercontent.com/assets/8806985/15015394/e7c71ba8-120b-11e6-9241-032dd8ad576b.png)
Plus Index for Login Attempts:![image](https://cloud.githubusercontent.com/assets/8806985/15015379/d86d457e-120b-11e6-9b0d-e40cdf94bc15.png)