search

rbCAS / CASino

CASino is a Ruby-based Single Sign-On solution supporting the CAS standard
MIT License
329 stars 189 forks source link

Rails 5 support! #168

Open eschartner opened 8 years ago

eschartner commented 8 years ago

Is there a reason why the Rails version has to be smaller than 4.3.0 ?

Because of this restriction I cannot upgrade to Rails 5.

Same issue for casino-activerecord_authenticator (activerecord dependency).

luxflux commented 7 years ago

The reason is that it's not tested against a Rails 5 app. Does it work for you if you loosen the dependencies?

AjayBarot commented 7 years ago

@luxflux : I added rails 5 dependency and this is test result.

Finished in 13.1 seconds (files took 7.54 seconds to load)
294 examples, 37 failures

I will let you know once i am done with these failed specs.

luxflux commented 7 years ago

Great, @AjayBarot! Looking forward to the PR 😄

AjayBarot commented 7 years ago

@luxflux : Please review this PR and I updated devise_cas_authenticatable too with rails 5. Please give your suggestion regarding this issue too. devise_cas_authenticatable

Thanks

jmmastey commented 7 years ago

@luxflux (cc @pencil I think?) checking in. I see this old conversation and PR with broken tests.

I've got a green running branch for Rails 5.0 and Rails 5.1 (it's a small number of actual changes). Is there interest in me generating a PR for it? I'd rather not run a hacked copy of CASino for my client's code.

It's here if that's most interesting: https://github.com/rbCAS/CASino/compare/master...jmmastey:rails-5?expand=1

Thanks!

joelvh commented 6 years ago

@jmmastey we've got a Rails 5.0 branch going too. I just created a PR for it here: https://github.com/rbCAS/CASino/pull/192

As mentioned in the other issue about maintainers (https://github.com/rbCAS/CASino/issues/189), we'll aim to maintain on our branch