search

rbCAS / CASino

CASino is a Ruby-based Single Sign-On solution supporting the CAS standard
MIT License
331 stars 189 forks source link

Fixed NameError #56

Closed plribeiro3000 closed 10 years ago

plribeiro3000 commented 10 years ago

The ROTP was being referenced without properly load. The require is enough to fix the issue.

Backtrace:

NameError - uninitialized constant ROTP: activesupport (4.1.4) lib/active_support/dependencies.rb:518:in load_missing_constant' activesupport (4.1.4) lib/active_support/dependencies.rb:180:inconst_missing' () Users/paulo/.rvm/gems/ruby-2.1.2@auth/bundler/gems/CASino-a2ec29c1a104/app/processors/casino/processor_concern/two_factor_authenticators.rb:12:in validate_one_time_password' () Users/paulo/.rvm/gems/ruby-2.1.2@auth/bundler/gems/CASino-a2ec29c1a104/app/processors/casino/second_factor_authentication_acceptor_processor.rb:24:inprocess' () Users/paulo/.rvm/gems/ruby-2.1.2@auth/bundler/gems/CASino-a2ec29c1a104/app/controllers/casino/sessions_controller.rb:30:in `validate_otp'

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.0%) when pulling 5f559f1ac822d8337b6690a507f0d39704dfa85b on zertico:fix_name_error into 23b005aa02ba1a9d5c8a76d65af2393409761e8d on rbCAS:master.

pencil commented 10 years ago

Thank you!

plribeiro3000 commented 10 years ago

:+1:

Is there any plannings to use Responder on the Controllers to make it possible to Change the render/ redirect behavior without the need of overwrite the actions?

pencil commented 10 years ago

Actually I'd like to do a big refactoring as I mentioned here but I don't have the time. Maybe later this year.

plribeiro3000 commented 10 years ago

Sure, Is there something i can help you? Maybe if you break it in smaller tasks. I would gadly help you out move from the processor/listener stuff to responder.

pencil commented 10 years ago

I made an issue. If you have an idea for a possible architecture, let me know. Cheers! :beers: