search

rbCAS / CASino

CASino is a Ruby-based Single Sign-On solution supporting the CAS standard
MIT License
331 stars 189 forks source link

Cherry pick fixes for #51 and #58 (closes #64) #65

Closed vbalazs closed 10 years ago

vbalazs commented 10 years ago

Backport fixes for login issues caused by custom route mount point.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling dfb32e0370be4f5421500a8ab9e35876d80ae7ef on digitalnatives:v2_maintenance into 21ef58202011149a55852de57a3d19dbd9fe5462 on rbCAS:2.0.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling dfb32e0370be4f5421500a8ab9e35876d80ae7ef on digitalnatives:v2_maintenance into 21ef58202011149a55852de57a3d19dbd9fe5462 on rbCAS:2.0.

vbalazs commented 10 years ago

@pencil What do you think? Should I look into backporting other bugfixes or is it enough for a 2.0.7 release? :)

pencil commented 10 years ago

Thank you! Think it should be enough for a bugfix release. Did you test it though?

vbalazs commented 10 years ago

Yes, these two commits solved my issues and the generic functionality still works. I haven't done full manual testing though.

Later tonight I'll test it with root mount point as well and get back to you. You can hold the merge until then.

vbalazs commented 10 years ago

@pencil I tested it with root mount point, it seems OK to me.

pencil commented 10 years ago

Thanks. Just released 2.0.7. :beers: