rbackhouse / MaximumMPD

React Native based MPD Client for iOS and Android
MIT License
46 stars 5 forks source link

search doesn't return all results #106

Closed guestguestguestguest closed 1 year ago

guestguestguestguest commented 1 year ago

When I enter the word "Stand" in the Search input field, the song 'Stand' by R.E.M. is not included in the results. But it is on my server and is listed by Browse. 7269 7268 7267 7266 7265

guestguestguestguest commented 1 year ago

Music Player Daemon 0.21.23 (0.21.23) Maximum MPD version 5.7

rbackhouse commented 1 year ago

I suspect this to due to a limit on the number items returned for a search. It is set for 50 and there is no priority set for exact matches.

It should really make sure exact matches are listed first and i would expect that would fix this scenario you are seeing.

guestguestguestguest commented 1 year ago

That makes sense. I agree that listing exact matches first would fix this. And maybe make the max search returns a settable configuration option, although 50 does seem quite reasonable for most cases.

rbackhouse commented 1 year ago

Version 5.8 now in the App Store should have a fix for this

guestguestguestguest commented 1 year ago

Thanks Richard. It doesn't appear in the App Store on my phone yet but I will install the update once I see it listed.

Frank

------- Original Message ------- On Saturday, July 15th, 2023 at 11:43 AM, Richard Backhouse @.***> wrote:

Version 5.8 now in the App Store should have a fix for this

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

guestguestguestguest commented 1 year ago

Hi Richard,

I just installed MaximumMPD 5.8 and I'm sad to report that the exact same use case still fails (search results for "Stand" does not list the song "Stand" by R.E.M.).

Frank

------- Original Message ------- On Saturday, July 15th, 2023 at 11:43 AM, Richard Backhouse @.***> wrote:

Closed #106 as completed.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

rbackhouse commented 1 year ago

Are you seeing the same order of songs returned as before or is it different ?

guestguestguestguest commented 1 year ago

It's different; all of the songs at the top of the list contain the bare word 'stand' in the title.
standSongs

rbackhouse commented 1 year ago

Ok, that suggests the the priority on the exact match for 'stand' is working but my guess is that the 50 limit is excluding it from the initial search results and never gets prioritized. I could make the search results limit configurable but I think I need to look into a better solution.

rbackhouse commented 1 year ago

I've got a new version in the app store that should hopefully fix the problem. The search function now perform 2 searches, the first looks for exact title matches and the second as it was previously. This should ensure that exact title matches show up first in the "Songs" section

guestguestguestguest commented 1 year ago

Fixed. Thanks Richard!

------- Original Message ------- On Saturday, August 12th, 2023 at 3:18 AM, Richard Backhouse @.***> wrote:

I've got a new version in the app store that should hopefully fix the problem. The search function now perform 2 searches, the first looks for exact title matches and the second as it was previously. This should ensure that exact title matches show up first in the "Songs" section

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>