rbalestr-lab / stable-SSL

https://rbalestr-lab.github.io/stable-SSL.github.io/dev/
MIT License
2 stars 1 forks source link

Customize run name based on training configs #26

Closed vipulSharma18 closed 1 hour ago

vipulSharma18 commented 2 hours ago

wandb and local run name to be generated automatically as per the training configs

RandallBalestriero commented 2 hours ago

wandb will automatically generate a name if none is given by the user. I would advocate against overriding the wandb logic to handle automatic name generation since the naming convention would be very user specific. Thoughts @huguesva ?

vipulSharma18 commented 2 hours ago

We're already overriding the naming convention with this: datetime.now().strftime("%Y%m%d_%H%M%S.%f")

So I thought I'll make it more meaningful by making it this: 'SimCLR_resnet9_eps_1000_optim_LARS' + '_' + datetime.now().strftime("%Y%m%d_%H%M%S.%f")

vipulSharma18 commented 2 hours ago

Code which overrides run name: https://github.com/rbalestr-lab/stable-SSL/blob/main/stable_ssl/config.py#L178

RandallBalestriero commented 2 hours ago

This is only for local folder, not for wandb. And the date time override is also aligned with Hydra logic and other frameworks (that the minimum info to add to make sure deduplication). However I would advise against using further customization with config args for the naming. If users want more personalization on that they can easily override that logic from the Trainer? @huguesva maybe we can add a method like name_folder that users can use to customize the naming from args?

huguesva commented 2 hours ago

I agree with @RandallBalestriero that we should not override the wandb logic.

huguesva commented 2 hours ago

yes ok for the name_foldermethod.

vipulSharma18 commented 1 hour ago

Change not required, closing issue.