Closed vipulSharma18 closed 1 hour ago
wandb will automatically generate a name if none is given by the user. I would advocate against overriding the wandb logic to handle automatic name generation since the naming convention would be very user specific. Thoughts @huguesva ?
We're already overriding the naming convention with this:
datetime.now().strftime("%Y%m%d_%H%M%S.%f")
So I thought I'll make it more meaningful by making it this:
'SimCLR_resnet9_eps_1000_optim_LARS' + '_' + datetime.now().strftime("%Y%m%d_%H%M%S.%f")
Code which overrides run name: https://github.com/rbalestr-lab/stable-SSL/blob/main/stable_ssl/config.py#L178
This is only for local folder, not for wandb. And the date time override is also aligned with Hydra logic and other frameworks (that the minimum info to add to make sure deduplication). However I would advise against using further customization with config args for the naming. If users want more personalization on that they can easily override that logic from the Trainer? @huguesva maybe we can add a method like name_folder
that users can use to customize the naming from args?
I agree with @RandallBalestriero that we should not override the wandb logic.
yes ok for the name_folder
method.
Change not required, closing issue.
wandb and local run name to be generated automatically as per the training configs