Closed HedgeComp closed 4 weeks ago
Please don't add other things to your PR that are different from the original intent of the PR (for example fixing the Unattend/PPKG issues). I had mentioned in another comment that I had known those issues were broken (the code was in place, I just hadn't gotten the new variables declared yet). I can't merge this PR now with those other items included.
Open additional PRs for new items. It makes it a lot easier to merge and either accept/deny the PRs. Thanks.
Hi @rbalsleyMSFT , I am very sorry for the confusion. I am honestly new to Github and etiquette of PR's for adding code to repositories.
I will simply Branch off the One Drive and Hours in to seperate code bases pulled from your most recent 2409.1 merger. I will add 2 seperate PRs for them now.
Once again I apologize, I am simply trying to learn and give back if I can.
cheers!
All good! Just resubmit. My plan is to push 2409.1 to main either today or Monday. Just have one last thing I want to add for the VM Switch validation that came up in another issue.
Depending on the install size of selected Updates and large applications installers like Autodesk or Adobe, FFU builds can take more than an hour. The display then rolls over the minutes and looks a little strange.
Made the following additional changes.
Add silent install switch for
Onedrive.exe /allusers /silent
Fix Issue #63