search

rbanffy / pip-chill

A more relaxed `pip freeze`
Other
557 stars 25 forks source link

Implement showing url for editable packages #18

Closed yoniLavi closed 3 years ago

yoniLavi commented 5 years ago

Hi Ricardo, Following our coding session earlier, I've implemented feature #8. The comments are slightly different since I actually accidentally lost the previous edits :( Any feedback is welcome Cheers

yoniLavi commented 5 years ago

Sorry, I tried to do a bit of archaeology around that get_requirement_info function in older versions of pip and was disappointed to see it was implemented in several different ways before this new incarnation, so it could be a bit of a mess to support it well on old versions of Python.

I assume that having it work for now only in the newer versions is better than nothing and have left a TODO comment.

github-actions[bot] commented 3 years ago

Stale pull request message

rbanffy commented 3 years ago

I think I forgot most of the context around this. Can you redo the PR against develop? The conflicts seem simple enough.

yoniLavi commented 3 years ago

Hi @rbanffy , I looked at it now and see my solution at the time isn't useful anymore. That's on me for trying to use an _internal function.

I played with it a bit and saw that we could now do it with FrozenRequirement, but seeing how these internals keep changing, it's probably not worth it, so I've closed the PR.

from pip._internal.operations.freeze import FrozenRequirement
...
FrozenRequirement.from_dist(distribution).req