rbanffy / pip-chill

A more relaxed `pip freeze`
Other
560 stars 25 forks source link

pip-chill should not be shown in the list #34

Closed cjerrington closed 3 years ago

cjerrington commented 3 years ago

Environment

Description

According to the main line "Make requirements with only the packages you need" pip-chill should not be listed when running pip-chill to not bloat the requirements.txt with this module. It is not needed in the virtual environment except to list the parent modules needed to install.

What I Did

pip-chill > .\requirements.txt

Still shows pip-chill==1.0.0 in the output. I have to install pip-chill in the virtual environment then I get the packages for the virtual environment I'm working in. If I install it globally and activate the virtual environment and run pip-chill I get the packages in the global environment.

cjerrington commented 3 years ago

Would this be added to the ignored_packages?


if show_all:
        ignored_packages = ()
    else:
        ignored_packages = {"pip", "wheel", "setuptools", "pkg-resources", "pip-chill"}
studioj commented 3 years ago

i added a PR so this was possible as an option ... https://github.com/rbanffy/pip-chill/pull/31

GregHilston commented 3 years ago

I'm not saying that this feature isn't a good idea, but here's how I've gotten around this situation in the past:

$ pip-chill | grep --invert-match pip-chill

Which will return all packages your environment requires that is not pip-chill

studioj commented 3 years ago

I'm not saying that this feature isn't a good idea, but here's how I've gotten around this situation in the past:

$ pip-chill | grep --invert-match pip-chill

Which will return all packages your environment requires that is not pip-chill

Indeed grep is handy on Unix devices...

Findstr exists on Windows but is much lesser known. ( Actually I didn't know until I just now searched 'grep for Windows :-P )

GregHilston commented 3 years ago

Oh good call totally forgot grep is not always available. Excellent point

On Sun, Jan 17, 2021, 5:53 PM studioj notifications@github.com wrote:

I'm not saying that this feature isn't a good idea, but here's how I've gotten around this situation in the past:

$ pip-chill | grep --invert-match pip-chill

Which will return all packages your environment requires that is not pip-chill

Indeed grep is handy on Unix devices...

Findstr exists on Windows but is much lesser known. ( Actually I didn't know until I just now searched 'grep for Windows :-P )

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rbanffy/pip-chill/issues/34#issuecomment-761895135, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAIFQGFQMFMX3IIT5RTPFLS2NS75ANCNFSM4VZVSVLA .