rbanffy / pip-chill

A more relaxed `pip freeze`
Other
555 stars 25 forks source link

Run tests on windows #44

Closed studioj closed 3 years ago

studioj commented 3 years ago

as requested PR for having tests runable on windows and having the 2.7 build pass

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.21%.

Quality metrics Before After Change
Complexity 4.38 ⭐ 4.02 ⭐ -0.36 👍
Method Length 34.06 ⭐ 38.30 ⭐ 4.24 👎
Working memory 7.48 🙂 7.88 🙂 0.40 👎
Quality 78.89% 77.68% -1.21% 👎
Other metrics Before After Change
Lines 321 353 32
Changed files Quality Before Quality After Quality Change
setup.py 53.93% 🙂 53.93% 🙂 0.00%
pip_chill/cli.py 65.16% 🙂 65.16% 🙂 0.00%
pip_chill/pip_chill.py 69.67% 🙂 69.67% 🙂 0.00%
tests/test_pip_chill.py 87.48% ⭐ 83.94% ⭐ -3.54% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pip_chill/pip_chill.py chill 22 😞 138 😞 8 🙂 49.23% 😞 Refactor to reduce nesting. Try splitting into smaller methods
tests/test_pip_chill.py TestPip_chill.test_pip_ommitted.test_all.test_hashes.test_command_line_interface_omits_ignored 1 ⭐ 61 ⭐ 10 😞 73.75% 🙂 Extract out complex expressions
tests/test_pip_chill.py TestPip_chill.test_pip_ommitted.test_all.test_hashes.test_command_line_interface_omits_ignored.test_command_line_interface_all.test_command_line_interface_short_all.test_command_line_interface_long_all.test_command_line_interface_doesnt_no_chill_by_default 0 ⭐ 55 ⭐ 10 😞 75.69% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.