search

rbanffy / pip-chill

A more relaxed `pip freeze`
Other
555 stars 25 forks source link

Run tests locally on windows #45

Closed studioj closed 2 years ago

studioj commented 3 years ago

as requested PR for having tests runnable on windows and having the 2.7 build pass

studioj commented 3 years ago

should i remove the 2.7 part? I see you disabled the build (but maybe thats because it was failing

rbanffy commented 3 years ago

The 2.7 removal was mostly because of the official Python abandonment of 2.7, so it makes sense to no longer worry too much about it. I think we can remove 2.7 now.

studioj commented 3 years ago

shoudl be ready to merge

rbanffy commented 3 years ago

From a quick look, it seems the Travis tests are failing because of the new crypto modules written in Rust. I'll need to add a Rust compiler to the config.

studioj commented 3 years ago

@rbanffy one remaining :-)

studioj commented 3 years ago

@rbanffy i dont know how important that dist: bionic was => but removing it made it work

github-actions[bot] commented 3 years ago

Stale pull request message

studioj commented 3 years ago

I think this is still a valid PR @rbanffy I reopened.

rbanffy commented 3 years ago

Agreed. If there is a need for this, we need to reassess.

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.25%.

Quality metrics Before After Change
Complexity 0.44 ⭐ 0.50 ⭐ 0.06 👎
Method Length 30.95 ⭐ 37.38 ⭐ 6.43 👎
Working memory 5.22 ⭐ 5.30 ⭐ 0.08 👎
Quality 89.23% ⭐ 87.98% ⭐ -1.25% 👎
Other metrics Before After Change
Lines 138 174 36
Changed files Quality Before Quality After Quality Change
tests/test_pip_chill.py 89.23% ⭐ 87.98% ⭐ -1.25% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

studioj commented 3 years ago

Explain reassess please. :) Can I do something? Or do you asume the project complete?

github-actions[bot] commented 2 years ago

Stale pull request message