search

rbanffy / selectric-mode

⌨ Make your Emacs sound like a proper typewriter.
GNU Lesser General Public License v3.0
158 stars 12 forks source link

Delete sound #11

Closed codesuki closed 7 years ago

codesuki commented 8 years ago

The keymap is now attached to the minor mode. I checked with describe-key that the keymap is not used if the minor mode is not used.

codesuki commented 8 years ago

My emacs indents the else branch of (if... so there are some lines changed. If you dislike that I can change it by hand. I think it's easier to understand. Did you set something specific to disable that? I guess you are using emacs too ;)

rbanffy commented 8 years ago

Yes, the indentations are a bit odd. I didn't say anything about them to my Emacs, but it could be something I added.

One question: do we need to restore the previous bindings when we use a mode-map?

codesuki commented 8 years ago

If the user disables the mode the mode map will be restored automatically.

rbanffy commented 8 years ago

Great! Just fix that odd indentation issue and we're good to merge.

codesuki commented 7 years ago

Sorry I totally forgot to push here :(

rbanffy commented 7 years ago

NP. Thanks for the patch.