rbardini / jsonresume-theme-even

A flat JSON Resume theme, compatible with the latest resume schema
https://jsonresume-theme-even.rbrd.in
MIT License
25 stars 31 forks source link

Error on `resume export` when `basics.summary` does not exist #10

Closed christopherseaman closed 3 years ago

christopherseaman commented 3 years ago

For making resumes without an "About" section.

To reproduce, in a clean dir:

  1. run resume init (fill in name/email)
  2. edit resume.json to delete the summary line in basics
  3. run resume export output.html -t even
  4. error occurs (output attached) error.txt

Tested and the same resume.json does export using the elegant theme and when a blank summary line ("summary": "",) is included although that produces an undesired blank summary line on the output as well (example).

Oddly enough, this seems to work as desired on registry.jsonresume.org (see attached pics with and without a blank summary line in the basics obj).

with_summary without_summary
rbardini commented 3 years ago

Thanks for the report, @christopherseaman! This has been fixed in v0.10.1.

Note that you may have to wait until the dependency version is updated in resume-cli, unless you use one of the other methods described in the README 😉

christopherseaman commented 3 years ago

Thanks for the (amazingly) quick response. Confirmed working.

resume.json on  master [✘?⇣] via ⬢ v15.11.0 on ☁️ christopher.seaman@gmail.com 
❯ resume export asdf.html -r resume_with_summary.json

Done! Find your new .html resume at:
 /Users/christopher/Documents/Development/resume.json/asdf.html

resume.json on  master [✘?⇣] via ⬢ v15.11.0 on ☁️ christopher.seaman@gmail.com 
❯ resume export asdf.html -r resume_without_summary.json

Done! Find your new .html resume at:
 /Users/christopher/Documents/Development/resume.json/asdf.html

resume.json on  master [✘?⇣] via ⬢ v15.11.0 on ☁️ christopher.seaman@gmail.com 
❯ npm list
resume.json@ /Users/christopher/Documents/Development/resume.json
└── jsonresume-theme-even@0.10.1