search

rbardini / resumed

👔 Lightweight JSON Resume builder, no-frills alternative to resume-cli
https://npm.im/resumed
MIT License
312 stars 25 forks source link

feat(theme)!: remove theme auto-load #4

Closed rbardini closed 1 year ago

rbardini commented 1 year ago

Replace theme auto-load with --theme option and .meta.theme resume field.

Although a nice feature, theme auto-load added a lot of complexity to the project (~30% of the code). Removing it also removes half the dependencies, and facilitates a future migration to ESM.

codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (a27fe04) compared to base (ec96392). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 5 -1 Lines 75 55 -20 Branches 10 6 -4 ========================================= - Hits 75 55 -20 ``` | [Impacted Files](https://codecov.io/gh/rbardini/resumed/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rafael+Bardini) | Coverage Δ | | |---|---|---| | [src/index.ts](https://codecov.io/gh/rbardini/resumed/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rafael+Bardini#diff-c3JjL2luZGV4LnRz) | `100.00% <ø> (ø)` | | | [src/cli.ts](https://codecov.io/gh/rbardini/resumed/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rafael+Bardini#diff-c3JjL2NsaS50cw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rafael+Bardini). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Rafael+Bardini)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: