search

rbardini / storybook-addon-paddings

🔲 A Storybook addon to add different paddings to your preview
https://storybook-addon-paddings.rbrd.in
MIT License
30 stars 2 forks source link

feat(reset): set preview margins and paddings to 0 by default #19

Closed rbardini closed 3 years ago

rbardini commented 3 years ago

Storybook 6.1 introduces the layout parameter, set to padded by default.

This PR sets the preview margins and paddings to 0 by default, so users are not required to change the layout option to fullscreen when using the addon. It also ensures that both are reset in older Storybook versions, or when the none option is used.

joanrm20 commented 3 years ago

hey @rbardini, are you planning to merge this first or #10 ?

rbardini commented 3 years ago

I think it would be better to merge this one first, so users don't need to upgrade to a major version to have it.

It might conflict with #10 though—I decided to use ranges in all example dependencies, so we always deploy with the latest supported versions. Is it ok for you?

joanrm20 commented 3 years ago

hey @rbardini, sounds good. After you merge this I can fix conflicts, we can test and merge #10.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: