rbarrois / python-semanticversion

Semantic version comparison for Python (see http://semver.org/)
BSD 2-Clause "Simplified" License
281 stars 74 forks source link

Improve NpmSpec parsing #116

Open gnattishness opened 3 years ago

gnattishness commented 3 years ago

Makes NpmSpec more closely match the node-semver implementation in what syntax it accepts as valid.

Resolves #115

gnattishness commented 3 years ago

I've left all the commits separate, but I'll squash them once you're happy with the review. Thanks for your time!

gnattishness commented 3 years ago

I also noticed that NpmSpec would probably accept v>0.1.2 as valid. I get that v isn't part of semver, but not sure if >v0.1.2 is preferred or neither. Happy to add something about this in, if you have any thoughts.

pgampe commented 1 year ago

What is missing here? The conflict is only in the changelog and needs to be resolved before merge anyway.

gnattishness commented 1 year ago

@pgampe Refer to the linked issue. The maintainer is waiting on clarification from the NPM semver implementers. If you'd like action here, I'd be happy for any progress in pushing for an answer from the NPM folks :)