Version bump to 2.7.0 does not adhere to Strict SemVer 2.0

rbarrois / python-semanticversion

Semantic version comparison for Python (see http://semver.org/)

BSD 2-Clause "Simplified" License

281 stars 74 forks source link

Version bump to 2.7.0 does not adhere to Strict SemVer 2.0 #78

Closed dnathe4th closed 5 years ago

dnathe4th commented 5 years ago

The new constructor leveraging Python3 syntax is a breaking change and should result in a major version bump to 3.0 per SemVer2.0

rbarrois commented 5 years ago

I'm not totally sure about this: should a version be bumped when one of its dependencies change? :wink:

However, if the issue is the loss of Python2 support, I would happily accept an external contribution to add that back in (only for the 2.x series).

rbarrois commented 5 years ago

This has been fixed in release 2.8.0; let me know if that's good ;)

dnathe4th commented 5 years ago

Thank you very much! You raise a great question. I would argue the addition of the bare asterisk is a breaking change even for anyone using python3 already because constructing a Version object now must be done with keyword arguments. It just happens to be that my complaint was py2 vs py3 related.