rbartlensky / Lua-interpreter

A Lua interpreter in Rust
5 stars 2 forks source link

Restructure and redesign the Lua compiler. #4

Closed rbartlensky closed 5 years ago

rbartlensky commented 5 years ago

Please review this PR first.

The Lua compiler has been redesigned and moved into its own crate. The new design includes:

This commit also moves the interpreter into its own crate, but it is unusable at the moment.

ltratt commented 5 years ago

We seem to have quite a few test failures?

rbartlensky commented 5 years ago

Sorry about that, it should be fine now. I retriggered the travis task.

rbartlensky commented 5 years ago

Ready for re-review.

ltratt commented 5 years ago

For the next PR, let's use rustfmt (we tend to prefer the style in https://github.com/softdevteam/packedvec/blob/master/.rustfmt.toml, but it's not an absolute requirement).

rbartlensky commented 5 years ago

Sure, I'll make sure to include rustfmt with my next pr! This is ready for another review.

ltratt commented 5 years ago

Please squash.

[I'd suggest doing a PR that's just rustfmt: it'll touch a lot of code, so we can get it over and done with in a mechanical way before moving to something more useful.]

rbartlensky commented 5 years ago

Squashed!