search

rbartram01 / tea_cozy

https://rbartram01.github.io/tea_cozy/
0 stars 0 forks source link

Page Rendering #1

Open sdhunt opened 6 years ago

sdhunt commented 6 years ago

Good work on implementing a page that looks good (and meets the project specification), at least initially.

When the browser window is widened, the Locations section remains on the left-hand side of the view, rather than being centered like the other sections.

This can be fixed, either by using flex layout (as you did with the other sections), or by using margin: 0 auto; for automatic left-right margin widths to share the "extra" space.

https://github.com/rbartram01/tea_cozy/blob/master/index.html#L14-L18 Also, the navigation links do not work as they should. Clicking on a link should reposition the page content with the selected section at the top of the viewport.

This can be fixed by giving the relevant elements ids and using those in the anchor elements. 

            <nav>
                <span><a href="#mission">Mission</a></span>
                <span><a href="#featured-tea">Featured Tea</a></span>
                <span><a href="#locations">Locations</a></span>
            </nav>

            ...

            <div id="mission">
              ...
            </div>

            <div id="featured-tea">
              ...
            </div>

            <div id="locations">
              ...
            </div>
rbartram01 commented 6 years ago

OK, Sorry about that, I didn't even realise the links moved the page. Again a stupid mistake. Yes I found the flex unit quite difficult but I didn't want to fall behind so just carried on as best as I could. When possible I am hoping to go back and restart the unit or go over the lessons again at least.

Again thank you for your comments, quite disappointed with myself for missing such simple pieces of code :/ I felt the pressure was on a bit for me to submit the project as I stress about falling behind.

Thanks

Rebecca